Fix JSON tag mismatch for metrics responses#137
Open
Nehanth67 wants to merge 1 commit intoapache:mainfrom
Open
Fix JSON tag mismatch for metrics responses#137Nehanth67 wants to merge 1 commit intoapache:mainfrom
Nehanth67 wants to merge 1 commit intoapache:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes JSON unmarshalling issues in CloudStack metrics APIs by updating response struct tags to match the actual API response keys. The CloudStack API returns metrics lists under singular entity names (e.g., "host", "zone"), but the Go structs were using incorrect plural/compound tags (e.g., "hostsmetric", "zonesmetric").
- Updated JSON tags for 6 metrics response structs to use singular entity names
- Aligned naming convention with other existing metrics responses in the codebase (ManagementServersMetrics, StoragePoolsMetrics, VirtualMachinesMetrics already use singular names)
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ZoneService.go | Changed ZonesMetrics JSON tag from "zonesmetric" to "zone" |
| VolumeService.go | Changed VolumesMetrics JSON tag from "volumesmetric" to "volume" |
| UsageService.go | Changed UsageServerMetrics JSON tag from "usageservermetric" to "usageserver" |
| InfrastructureUsageService.go | Changed DbMetrics JSON tag from "dbMetrics" to "db" |
| HostService.go | Changed HostsMetrics JSON tag from "hostsmetric" to "host" |
| ClusterService.go | Changed ClustersMetrics JSON tag from "clustersmetric" to "cluster" |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CloudStack metrics APIs return lists under updated JSON keys (e.g.
"host"for host metrics).The cloudstack-go response structs still used older json tags (e.g.
"hostmetric"/"hostmetrics"),causing unmarshalling issues where metrics lists become nil/null.
This PR updates the relevant response struct json tags to match the actual CloudStack API response keys.